[VM] Trivial bugs in vm-8.2.0b

[Dr Rainer Woitok]

Uday,

after downloading and compiling vm-8.2.0b (which seems to date back to
the end of 2012!) for XEmacs 21.4 I found out that I could neither open
the VM NEWS file nor the VM Manual from the "Help" pull down menu. To
remedy this I did the following trivial changes:

--- vm-menu.el.~1~ 2011-12-28 00:19:28.000000000 +0200
+++ vm-menu.el 2013-07-21 18:07:44.306000000 +0200
@@ -315,7 +315,7 @@
["Customize VM" vm-customize t]
["Describe VM Mode" describe-mode t]
["VM News" vm-view-news t]
- ["VM Manual" vm-menu-view-manual t]
+ ["VM Manual" vm-view-manual t]
["Submit Bug Report" vm-submit-bug-report t]
"---"
["What Now?" vm-help t]
@@ -1466,7 +1466,7 @@
(file-exists-p (expand-file-name "NEWS" doc-dir)))
(setq doc-dirs nil)
(setq doc-dirs (cdr doc-dirs))))
- (view-file-other-frame (expand-file-name "NEWS" doc-dir))))
+ (find-file-other-frame (expand-file-name "NEWS" doc-dir))))

(defun vm-view-manual ()
"View the VM manual."

Then I found out that I could not start writing a mail by hitting "m"
(M-x vm-mail) because function "vm-select-recipient-from-sender" was un-
defined. I remedied this by doing:

--- vm-reply.el.~1~ 2011-12-28 00:19:28.000000000 +0200
+++ vm-reply.el 2013-07-21 19:11:19.952000000 +0200
@@ -1643,6 +1643,7 @@
(add-hook 'vm-mail-send-hook 'vm-forget-composition-buffer nil t)
(vm-update-ml-composition-buffer-count))

+;;;###autoload
(defun vm-select-recipient-from-sender ()
"Select a recipient's address from the current message's sender, if
there is a current message."

These all are so trivial glitches that I really wonder why one and a
half years later I should be the first one to stumble upon them?

Sincerely
Rainer

----------------------------------------------------------------------
| Rainer M Woitok | Phone : [phone] |
| Kolpingstraße 3 | Mobile: [phone] |
| D-63846 Laufach | Mail : ***@Gmail.Com |
| Germany | |
----------------------------------------------------------------------

[Dr Rainer Woitok]

Uday,

Post by Dr Rainer Woitok
...
after downloading and compiling vm-8.2.0b (which seems to date back to
the end of 2012!) for XEmacs 21.4

There's one thing I forgot to mention: running "./configure ..." pro-
duced two warnings, and I just cannot tell whether they are trivial and
to be ignored or are sort of important:

"xemacs" -batch -no-autoloads -l ./vm-build.el -f batch-byte-compile vm-dired.el
Compiling /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.el...
Loading dired-mule...
While compiling vm-dired-do-attach-files in file /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.el:
** evaluating (= nil 0): (wrong-type-argument number-char-or-marker-p nil)
** evaluating (< nil 0): (wrong-type-argument number-char-or-marker-p nil)
Wrote /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.elc
Done

Sincerely
Rainer

----------------------------------------------------------------------
| Rainer M Woitok | Phone : [phone] |
| Kolpingstraße 3 | Mobile: [phone] |
| D-63846 Laufach | Mail : ***@Gmail.Com |
| Germany | |
----------------------------------------------------------------------

[Uday Reddy]

Post by Dr Rainer Woitok
"xemacs" -batch -no-autoloads -l ./vm-build.el -f batch-byte-compile vm-dired.el
Compiling /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.el...
Loading dired-mule...
** evaluating (= nil 0): (wrong-type-argument number-char-or-marker-p nil)
** evaluating (< nil 0): (wrong-type-argument number-char-or-marker-p nil)
Wrote /home/Rainer/prod/vm-8.2.0b/lisp/vm-dired.elc
Done

Thanks for reporting. They do look like warnings because the compilation
got completed.

The code of `vm-dired-do-attach-files' uses a macro caled
`dired-map-over-marks' defined in the Emacs library. There are possibly
some problems with the macro. In GNU Emacs, it works fine for me. If you
are able to test this function in XEmacs, please let me know if it works.

Cheers,
Uday

[Dr Rainer Woitok]

Uday,

Post by Uday Reddy
...
The code of `vm-dired-do-attach-files' uses a macro caled
`dired-map-over-marks' defined in the Emacs library. There are possibly
some problems with the macro. In GNU Emacs, it works fine for me. If you
are able to test this function in XEmacs, please let me know if it works.

Here's what I got:

Loading vm-dired...
vm-dired not supported in Emacs version 21.4 (patch 22) "Instant Classic" XEmacs Lucid

Sincerely
Rainer

----------------------------------------------------------------------
| Rainer M Woitok | Phone : [phone] |
| Kolpingstraße 3 | Mobile: [phone] |
| D-63846 Laufach | Mail : ***@Gmail.Com |
| Germany | |
----------------------------------------------------------------------

[John Stoffel]

Rainer> Then I found out that I could not start writing a mail by
Rainer> hitting "m" (M-x vm-mail) because function
Rainer> "vm-select-recipient-from-sender" was un- defined. I remedied
Rainer> this by doing:

Rainer> --- vm-reply.el.~1~ 2011-12-28 00:19:28.000000000 +0200
Rainer> +++ vm-reply.el 2013-07-21 19:11:19.952000000 +0200
Rainer> @@ -1643,6 +1643,7 @@
Rainer> (add-hook 'vm-mail-send-hook 'vm-forget-composition-buffer nil t)
Rainer> (vm-update-ml-composition-buffer-count))

Rainer> +;;;###autoload
Rainer> (defun vm-select-recipient-from-sender ()
Rainer> "Select a recipient's address from the current message's sender, if
Rainer> there is a current message."

Rainer> These all are so trivial glitches that I really wonder why one and a
Rainer> half years later I should be the first one to stumble upon them?

This patch is corrupt and makes no sense, but it does match some of
the problems I run into a points.

Using 8.2.0b, if I start up VM with my basic autoloads setup, I can't
compose a new email without doing 'r' to reply to an existing email,
then killing that buffer. Then I can to 'm' to compose an email.

So your patch made me interested to fix my vm-reply.el, but I don't
see that hook or any of those matching lines in the code.

John

[Dr Rainer Woitok]

John,

Post by John Stoffel
...
Rainer> --- vm-reply.el.~1~ 2011-12-28 00:19:28.000000000 +0200
Rainer> +++ vm-reply.el 2013-07-21 19:11:19.952000000 +0200
Rainer> (add-hook 'vm-mail-send-hook 'vm-forget-composition-buffer nil t)
Rainer> (vm-update-ml-composition-buffer-count))
Rainer> +;;;###autoload
Rainer> (defun vm-select-recipient-from-sender ()
Rainer> "Select a recipient's address from the current message's sender, if
Rainer> there is a current message."
...
This patch is corrupt and makes no sense,

What do you mean by that? I do frankly admit that I'm totally unaware
of any unwanted consequences of this change, it definitely WAS a blind
shot, but it worked. However, you need not only change "vm-reply.el"
but you must also remove "vm.elc" from the "lisp/" directory, so this
file, too, will be compiled again when you run "configure".

Post by John Stoffel
...
So your patch made me interested to fix my vm-reply.el, but I don't
see that hook or any of those matching lines in the code.

The hooks are irrelevant, because these lines belong to the function be-
ing defined ahead of "vm-select-recipient-from-sender". Just search
"vm-reply.el" for the string "(defun vm-select-recipient-from-sender"
and then insert ";;;###autoload" immediately before this line.

Sincerely
Rainer

----------------------------------------------------------------------
| Rainer M Woitok | Phone : [phone] |
| Kolpingstraße 3 | Mobile: [phone] |
| D-63846 Laufach | Mail : ***@Gmail.Com |
| Germany | |
----------------------------------------------------------------------