[VM] vm 8.1.1 and emacs 24 (make-local-hook)

[Reinhard Kotucha]

Hi, I'm using VM 8.1.1 with Emacs 23 for a while without any problems.
When I switch to Emacs 24 I get a complaint that the function
make-local-hook is void.

The Emacs 24 NEWS file states:

| ** The following obsolete functions and aliases have been removed
| (the appropriate new function is given in parentheses; "not needed"
| means you can just remove all calls to the function in question):
|
| [stuff omitted]
| *** `make-local-hook' (not needed)
| [stuff omitted]

According to "grep -r make-local-hook ./vm/*" it's still used in some
places. It doesn't occur in Emacs-24's top-level lisp directory. In
some subdirectories it's still present, but I see that there are some
functions called "gnus-make-local-hook" or "mh-make-local-hook". I
suppose that they are supposed to sustain the same functionality under
another name. Maybe something like "vm-make-local-hook" is needed as
a workaround...

However, I'm not urged to switch to Emacs 24 in the near future. I'm
perfectly satisfied with Emacs 23. But on the other hand I'm
maintaining an Emacs+AucTeX distribution for Windows on CTAN,
containing Emacs-24 for a while, and it's a bit awkward if I can't use
the same version of Emacs on my Linux machine at home.

After all, Uday, many thanks to you for your work and to all who have
contibuted, one way or another.

Regards,
Reinhard

[Uday Reddy]

Post by Reinhard Kotucha
Hi, I'm using VM 8.1.1 with Emacs 23 for a while without any problems.
When I switch to Emacs 24 I get a complaint that the function
make-local-hook is void.

Dear Reinhard, thanks for reporting. I will create an updated release of
8.1.x for working with Emacs 24. Stay tuned!

Cheers,
Uday

[Uday Reddy]

Dear Reinhard, If you build your own VM, here is a quick fix. Please put
this definition in vm-misc.el:

(defun vm-make-local-hook (hook)
(if (fboundp 'make-local-hook) ; Emacs/XEmacs 21
(make-local-hook hook)))

and replace all calls to make-local-hook in .../vm/lisp directory to calls
to vm-make-local-hook. Then recompile by doing

make clean; make

in the lisp directory.

I am trying to get you off the ground with Emacs 24 so that you can check
what other problems might arise in Emacs 24.

Cheers,
Uday

[Reinhard Kotucha]

Post by Uday Reddy
Dear Reinhard, If you build your own VM, here is a quick fix. Please put
(defun vm-make-local-hook (hook)
(if (fboundp 'make-local-hook) ; Emacs/XEmacs 21
(make-local-hook hook)))
and replace all calls to make-local-hook in .../vm/lisp directory to calls
to vm-make-local-hook. Then recompile by doing
make clean; make
in the lisp directory.
I am trying to get you off the ground with Emacs 24 so that you can check
what other problems might arise in Emacs 24.

Thank you very much, I'll look into it tomorrow. We Central Europeans
are one hour in advance and I have to get up early in the morning.

Anyway, thanks for this amazingly fast response.

Regards,
Reinhard

[l***@hare.demon.co.uk]

vm-8.2.0b fixed this. It seems stable and I haven't come across any
regressions.

Post by Reinhard Kotucha

Post by Uday Reddy
Dear Reinhard, If you build your own VM, here is a quick fix. Please put
(defun vm-make-local-hook (hook)
(if (fboundp 'make-local-hook) ; Emacs/XEmacs 21
(make-local-hook hook)))
and replace all calls to make-local-hook in .../vm/lisp directory to calls
to vm-make-local-hook. Then recompile by doing
make clean; make
in the lisp directory.
I am trying to get you off the ground with Emacs 24 so that you can check
what other problems might arise in Emacs 24.

Thank you very much, I'll look into it tomorrow. We Central Europeans
are one hour in advance and I have to get up early in the morning.
Anyway, thanks for this amazingly fast response.
Regards,
Reinhard
--
----------------------------------------------------------------------------
Reinhard Kotucha Phone: [phone]
Marschnerstr. 25
----------------------------------------------------------------------------
Microsoft isn't the answer. Microsoft is the question, and the answer is NO.
----------------------------------------------------------------------------

[Reinhard Kotucha]

Post by l***@hare.demon.co.uk
vm-8.2.0b fixed this. It seems stable and I haven't come across any
regressions.

This works perfectly for me too. However, I still send you this mail
from Emacs-23 because I have to adapt the SMTP configuration. I'm
asked for my SMTP username and password now but this is obviously not
related to VM.

Thank you very much and best regards,
Reinhard