Discussion:
[VM] displaying the right message after leaving virtual folder
Manuel Hermenegildo
2012-02-19 19:05:53 UTC
Permalink
Dear Uday and all,

when returning to a message folder after visiting a virtual folder
later vm versions try to return to the message selected in the virtual
folder. This is indeed very useful (as indicated in the manual) so
that virtual buffers can be used to perform a search, and I use this
great feature a lot lately (thanks Uday!). However, the current
behavior has confused me a number of times. To reproduce:

- Open folder F, move to some random messag M1.
- Create a virtual folder V, move to message M2.
- Quit V ("q").

At this point VM returns to F and internally it is correctly at
message M2 (and this is reflected in the summary). However, the
message actually displayed is not M2 but M1 (while the message number
in the mode line is the correct one corresponding to M2).

This has confused me several times since, seeing M1 in front of me, I
have hit reply, thinking that I was replying to M1 but the reply is
sent to the sender of M2!

This is specially confusing if you prefer (like me) to not see the
summary always there, by using, e.g.:

(setq vm-mutable-frames nil)
(setq vm-mutable-windows nil)

In this case when you quit V and go to F the only thing you see is M1
but if you hit reply you reply to M2 --ouch!

Simply adding a call to vm-refresh-message at the end of vm-quit:

(vm-update-summary-and-mode-line)))
-->
(vm-update-summary-and-mode-line)
(vm-refresh-message)))

seems to solve the problem, but I am not 100% sure this is the right
approach or that it covers all the cases...

Manuel

--
Uday Reddy
2012-02-19 20:16:44 UTC
Permalink
Hi Manuel,

Thanks, that is a subtle but serious problem.

The attached patch should correct the immediate problem, but I will be
commiting a more systematic solution to the code base.

Cheers,
Uday
Julian Bradfield
2012-03-06 12:59:10 UTC
Permalink
Post by Uday Reddy
Hi Manuel,
Thanks, that is a subtle but serious problem.
I guess this also explains the occasional failure of vm-multdom to
choose the right sender address. I couldn't reproduce it, but now it
seems that I can reproduce it by visiting a virtual folder.

Continue reading on narkive:
Loading...